TatriX / pomidor

Pomidor is a simple and cool pomodoro technique timer.
238 stars 17 forks source link

Tick/tack sounds are not played (Emacs can play audio) #50

Closed ig-perez closed 3 years ago

ig-perez commented 3 years ago

Hi thanks for building this package. For some reason tick/tack sounds are not played even if Emacs can play sound, for example (play-sound-file pomidor-sound-overwork) plays the bell sound.

This is my configuration:

(use-package pomidor
  :ensure t
  :bind (
     ("<f12>" . pomidor)
     )
  :config
  (setq
   pomidor-sound-tick t
   pomidor-sound-tack t
   pomidor-sound-overwork (expand-file-name (concat pomidor-dir "overwork.wav"))
   pomidor-sound-break-over "/home/sounds/520998__saviraz__boxing-bell-signals.wav"
   pomidor-seconds (* 25 60)
   pomidor-break-seconds (* 5 60)
   pomidor-breaks-before-long 2
   pomidor-long-break-seconds (* 10 60)
   )
  :hook (pomidor-mode . (lambda ()
                          (display-line-numbers-mode -1) ; Emacs 26.1+
                          (setq left-fringe-width 0 right-fringe-width 0)
                          (setq left-margin-width 2 right-margin-width 0)
                          ;; force fringe update
                          (set-window-buffer nil (current-buffer))))
  )

Thanks

TatriX commented 3 years ago

I believe that pomidor-sound-tick and pomidor-sound-tack should be a path to a file rather then t Check defcustom definition:

(defcustom pomidor-sound-tick (expand-file-name (concat pomidor-dir "tick.wav"))
  "Tick sound during a pomoro run."
  :type '(file :must-match t)
  :group 'pomidor)
ig-perez commented 3 years ago

My bad. I added the path and now works. Thanks! ... I'd recommend adding this to the readme.md. There are two code snippets where tick and tack appear, in both cases they are set to nil.