search

Tatsh / tatsh-overlay

Personal Gentoo Portage overlay.
https://tatsh.github.io/tatsh-overlay/
GNU General Public License v2.0
35 stars 10 forks source link

dbeaver-bin nitpicks #164

Closed PF4Public closed 1 year ago

PF4Public commented 1 year ago

https://github.com/Tatsh/tatsh-overlay/blob/e73fc952413eb405276094d45a6db6791f9b421d/dev-db/dbeaver-bin/dbeaver-bin-22.2.4.ebuild#L42-L43

This fails if dev-java/openjdk:11 is merged. Honestly saying I don't know what could be the proper fix.

BTW: does it support openjdk:17?

Tatsh commented 1 year ago

17 seems to work fine.

Tatsh commented 1 year ago

I switched it to 17. It seems there's no nice way to pick the 'default VM' for this.

PF4Public commented 1 year ago

For non-bin jdk removing -vm parameter works just fine. Could it be, that it can find -bin jdk in the same manner?

Tatsh commented 1 year ago

Yes I was forcing version 11 (though I should have made it dynamic with regards to the path) because it's listed in the dependencies. I think I can just make it require virtual/jre:17 and not patch the script.