search

Tatsh / tatsh-overlay

Personal Gentoo Portage overlay.
https://tatsh.github.io/tatsh-overlay/
GNU General Public License v2.0
35 stars 10 forks source link

games-emulation/citra: add missing dep #202

Closed Scall closed 1 year ago

Scall commented 1 year ago

fdk-aac is needed by the HLE AAC Decoder:

In file included from /var/tmp/portage/games-emulation/citra-20230804-r1/work/citra-5b52849f901fbdfbdbb8a81728b3233307445d0c/src/common/dynamic_library/fdk-aac.cpp:8:
/var/tmp/portage/games-emulation/citra-20230804-r1/work/citra-5b52849f901fbdfbdbb8a81728b3233307445d0c/src/./common/dynamic_library/fdk-aac.h:8:10: fatal error: fdk-aac/aacdecoder_lib.h: No such file or directory
    8 | #include <fdk-aac/aacdecoder_lib.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
Tatsh commented 1 year ago

Can you put this under USE flag fdk? It should be set by -DENABLE_FDK=$(usex fdk) to CMake. Also metadata.xml needs an update for this flag.

Tatsh commented 1 year ago

My understanding based on the link is that the AAC decoder is not specifically the FDK one. Based on the configuration it seems FFmpeg or FDK can be used.

Tatsh commented 1 year ago

Nevermind. FDK was optional a while ago but now it is required for building. I am putting fdk-aac in RDEPEND and BDEPEND.