search

Tatsu-syo / noMeiryoUI

No!! MeiryoUI is Windows system font setting tool on Windows 8.1/10/11.
https://www.tatsu-syo.info/MySoft/WinCust/index.html
MIT License
4.71k stars 163 forks source link

Improve grammar and follow GitHub's conventions on README #73

Closed mon-jai closed 11 months ago

mon-jai commented 11 months ago

I am still in the process of fine-tuning wordings and grammar. Do not merge yet.

Tatsu-syo commented 11 months ago

Thank you for your great work, There is no problem. I will merge it soon.

mon-jai commented 11 months ago

@Tatsu-syo Thanks for your comment. Why closing the PR?

mon-jai commented 11 months ago

If you plan to merge the changes in the future, remember to attribute me with git commit author field, or with Co-authored-by trailer supported by GitHub.

Tatsu-syo commented 11 months ago

I don't know right procedure to merge. And missing more works. Reopen this issue.

Tatsu-syo commented 11 months ago

Futher work in after my public work, sory.

Tatsu-syo commented 11 months ago

@mon-jai I merge and git commit --amend and add Co-authored-by credits. I am not familiar with Co-authored-by commits. How about this way? If you know better way, please tell me how to add Co-authored-by information. Thank you and sorry.

Tatsu-syo commented 11 months ago

@mon-jai I merge via GitHub with Co-authored-by. How about?

mon-jai commented 11 months ago

Yeah I saw it in the master branch.

Thanks for including my work.

Tatsu-syo commented 11 months ago

It was a good experience for me too.

Thank you for your contribution.