search

TatsuUkraine / dart_environment_config

Environment specific config generator for Dart and Flutter applications during CI/CD builds
https://pub.dev/packages/environment_config
BSD 3-Clause "New" or "Revised" License
92 stars 8 forks source link

Please use version contstraint in pubspec.yaml #15

Closed alfinbi closed 4 years ago

alfinbi commented 4 years ago

this package is hard to use while developing angulardart because of conflicting dependency.

as stated in dart.dev, For a library package that you want users to reuse, though, it is important to specify version constraints.

TatsuUkraine commented 4 years ago

Hello. Thank you for this issue. Sorry, but I'm not sure that I'm flowing. Could you explain more what issue is?

TatsuUkraine commented 4 years ago

You mean to use >=... instead of ^?

TatsuUkraine commented 4 years ago

@alfinbi I figured out what you mean) fix is provided in 2.2.1

TatsuUkraine commented 4 years ago

@alfinbi if it's not what you expected, please let me know. https://github.com/TatsuUkraine/dart_environment_config/pull/16/files#diff-fb2d52cd953afedcafc9fe7629c6f132

alfinbi commented 4 years ago

Yes, that was what I mean. But I think you should use range from the lowest to the highest. Example :

dart_style: ">=1.0.0 <2.0.0"

Since angular depends on dart_style 1.3.2, your package will never be used as dependency in angulardart app because in your package dart_style starts from 1.3.3.

TatsuUkraine commented 4 years ago

@alfinbi second attempt)) now all should be good https://github.com/TatsuUkraine/dart_environment_config/pull/19/files#diff-fb2d52cd953afedcafc9fe7629c6f132R13

alfinbi commented 4 years ago

Thanks a lot for your effort. Now I can use your package in my angulardart project.