search

TatuLund / badge

Simple Java API for Lumo Badges
Other
0 stars 0 forks source link

Badge theming and styling didn't work with Vaadin 23.0 #1

Closed karstenlehmann closed 2 years ago

karstenlehmann commented 2 years ago

The badge component didn't react to the given themes and variants with Vaadin 23.0.2

TatuLund commented 2 years ago

I can confirm this. Something has changed how one should import the badge styles in Vaadin 23 vs Vaadin 14

TatuLund commented 2 years ago

The original code did not show any error in Vaadin 23. I would assume that it should work, and the fact it does not work is probably a bug in Vaadin 23.

However I refactored the add-on to be web component wrapper and imported the styles in the web component and it seems to work well that way.

Use version 2.0.0 with Vaadin 23. Java API is unchanged.

karstenlehmann commented 2 years ago

I can confirm - it works now. Thank you