search

TatuLund / badge

Simple Java API for Lumo Badges
Other
0 stars 0 forks source link

Badges have two layers of background #4

Closed HerbertsVaadin closed 1 year ago

HerbertsVaadin commented 1 year ago

This is on Vaadin 24. image

looks like it badge styling applies on the outer element as well, based on theme image image

I think if the badge is inside the shadowdom (and no badge styling imported for that shadowdom) then it applies properly only on the inner level. It was nice when it was just the span element in the version 1.0.0, but I guess it didn't work for v23?

new Badge("3")
TatuLund commented 1 year ago

Yes. For me this looks intentional based on the imported styles. I.e. it is not a fault of the add-on. But it is change in Vaadin 24.1. I will add API to disable the feature as you pointed it is not nice in all cases.

TatuLund commented 1 year ago

Try out version 2.4.0

HerbertsVaadin commented 1 year ago

Solved with 2.4.0! Thanks!