search

Tau-ri-Dev / Mod-JSG-1.12.2

Just Stargate Mod for Minecraft (1.12.2)
https://JustSGMod.eu
Other
33 stars 22 forks source link

Bug: Stargates in Sponge dimensions are not detected #326

Closed san-antonio0978 closed 7 months ago

san-antonio0978 commented 7 months ago

Describe the bug On a server running SpongeForge, Stargates from the latest version of JSG (4.11.2.6) which are in custom Sponge dimensions (there can be several dimensions of type "overworld", type "nether", etc. ), are not detected.

Before updating JSG to version 4.11.2.6 (latest version), I was using version 4.11.0.8, when I was using this version, everything worked perfectly, Stargates in Sponge's custom dimensions were detected.

Here is what I get in the server logs whenever I try to dial a Stargate that is in a SpongeForge custom dimension:

[17:13:50] [Server thread/ERROR] [jsg]: Tried to perform a group check for a non-existing dimension. This is a bug.

[17:13:50] [Server thread/ERROR] [jsg]: Tried to perform a group check for a non-existing dimension. This is a bug.

[17:13:54] [Server thread/ERROR] [jsg]: Tried to perform a group check for a non-existing dimension. This is a bug.

To Reproduce Steps to reproduce the behavior:

  1. Run a SpongeForge Server with JSG-1.12.2-4.11.2.6 installed
  2. Install "Nucleus" plugin to manage Sponge dimensions
  3. Create new Sponge dimensions using the Nucleus command : /world create .............
  4. Build Stargates in these newly created dimensions
  5. Dial these newly built gates from any other dimension

Expected behavior Dial will always fail as the Sponge dimension is considered non-existent. Maybe using numerical IDs for dimensions could fix the issue, instead of / in addition to using the dimension type like "the_overworld", "the_nether", because there can be several "the_overworld" dimensions ?

Server Full Logs latest.log

Mod version jsg-1.12.2-4.11.2.6 (Server version) (on a SpongeForge server)

Additional context Before updating JSG to version 4.11.2.6 (latest version), I was using version 4.11.0.8, when I was using this version, everything worked perfectly, Stargates in Sponge's custom dimensions were detected.

My whole JSG config (as .zip) Default Config

MR-Spagetty commented 7 months ago

JSG already uses dim ids rather than dimension names, this issue is likely caused by either spongeforge jank or by the dimensions being made while the server is running, can you check if new gates placed in the diemsniosn after a server reboot work

san-antonio0978 commented 7 months ago

I finally found out what was the issue, in fact the "jsgDimensions_2.0.json" config file didn't generate, which is pretty weird after several server restarts, I should have noticed it immediately, so I had to add it manually, I then configured all the dimensions with dim IDs, names, groups, etc. and it now works perfectly.

This is why even after several server restarts, the stargates did not work, the file "jsgDimensions_2.0.json" was simply missing, and even after several server restarts, the file did not generate.

I apologize for the inconvenience.

MR-Spagetty commented 7 months ago

Ah so it was spongeforge jank