search

TavoNiievez / module-foundry

Foundry module for Codeception.
MIT License
1 stars 1 forks source link

Next Major Release V2 #3

Open jmwamser opened 11 months ago

jmwamser commented 11 months ago

Also associated with #1

I figured creating the next major to take out the older dependencies would be good.

I did skip a few of the modules v2 since they are already on v3. Let me know your thoughts.

Also if i need to change this to merge differently let me know.

fixes #1

jmwamser commented 11 months ago

Before Approving this version. I am going to add a few other tests.

TavoNiievez commented 11 months ago

Hi @jmwamser Once the Release 1.1 PR has been merged, it is necessary to solve the conflicts generated with the new changes in the main branch. Please resolve them to tag both versions.

the-juju commented 9 months ago

Hey guys, any update on it ? @jmwamser @TavoNiievez Thanks for the module @TavoNiievez And thanks for your recent work @jmwamser

jmwamser commented 9 months ago

I have been working on a few updates on this. just haven't pushed them up yet. Im swamped the next couple of days, so I wont be able to get to this till the 4th or later. this update should have all the same as v1.1. just restricting the versions a bit more for forward development.

I will try and jump on this soon though.

the-juju commented 9 months ago

Thank you for the quick answer. I'll find a workaround, but I really look forward for the next update !

jmwamser commented 8 months ago

@TavoNiievez, could you take a look and let me know your thoughts? I believe we are good to go. :)

TavoNiievez commented 8 months ago

Hi @jmwamser I don't think static code analysis tools should be part of the code in this repository. Therefore, the following files should be removed:

.editorconfig
.php-cs-fixer.dist.php
Makefile
development.md
phpmd.dist.xml
phpstan.dist.neon

On the other hand, Could you explain to me why you think it is necessary to create an abstract class?

jmwamser commented 8 months ago

@TavoNiievez why do you think not to have static analysis? I can get those taken out. I'm still in the learning process and would love your input. I was using them since we were going from PHP 7 & PHP 8 support to PHP 8 only support from V1 to V2. Would Rector have been a better option?

Should we have any tests in this library? Is there a different recommended setup you would go with? Like adding this lib into a project and using it to see what works and what doesn't.

On the other hand, Could you explain to me why you think it is necessary to create an abstract class?

Honestly, purely to follow the static analysis and make it happy. I built it with the abstract with the idea of extension in mind. Looking at it now and thinking about "what" extension I can't think of any. I think putting it back together would be better. Static Analysis should work for us, not us for it. As well taking Static out means it's not even a worry anymore anyways.

I'll look into this later this week, shouldn't take too long.