search

Tavvi / Dasmoto-s-Arts-Crafts-website

First project to be submitted for revision to codecademy.com
0 stars 0 forks source link

Summary #3

Open mikebutts opened 6 years ago

mikebutts commented 6 years ago

Grade: Needs Improvement

Summary: This might have looked closer to the spec had the CSS be applied, as it stands it did not look like the spec. One thing I would like to point out, is the organization of code, while this was actually neat and easy to read I'd like to go a step further and add divs between sections. div for the header then div for each set of h1,p,img . This will make the code a lot neater and easier to read down the road. So get the css applied, add some divs, and you will be in business!

Tavvi commented 6 years ago

Thanks for the suggestions. I just figured what happened. Drag an drop the folder did not work for me yesterday for whatever reason ,so I just dropped the .html and .css files with no directory without thinking that was not going to work at all of course! GitHub newbie. I just got everything fixed. So, you suggest to use divs sort of like nav is used? I was thinking that a div would only be necessary if an attribute is going to be assigned to it, but I see your point.