Missing error handling for user input in modals

[Tawmy]

When using the /configure command and entering a value for an integer configuration option, the bot shows a modal with a text input (since that is the only kind of input it supports). This input allows the user to input any text, not just whole numbers like the integer field would require. When the user enters invalid text like "abc" and confirms the input, the modal loads for a few seconds, then shows a generic screenshot.

It is not possible to restrict the input to just numbers, so there needs to be a validation when the user submits the input.

Todo:

• [x] Check if modals allow for feedback to the user

If they do:

• [ ] Validate input on submit
• [ ] Instead of generic error, show clear error about data type being wrong and show correct input

If they do not:

• [x] Validate input on submit
• [x] Cry
• [ ] Keep showing generic error
• [x] Show ephemeral message about data type being wrong and show correct input

The latter would not be great considering the user would only see it once they've closed the modal.

[Tawmy]

So it seems there is no way to validate user input. Hopefully an ephemeral can give the user some feedback without being all too distracting. It's not a great solution but it is the only one I can think of.

[Tawmy]

"Solution" (more like a workaround) has been implemented. When the user inputs invalid integer or decimal values, the bot now shows a more specific error like below.

https://user-images.githubusercontent.com/22292560/202849243-93215f2c-ed5a-43e3-b7fb-cc8b5c232cac.mov

[Tawmy]

Checks for QA:

• [ ] Do config options with int/decimal values still save on valid input?
• [ ] Does invalid input show the appropriate error for each data type?
• [ ] Does clicking the button reopen the modal?
• [ ] Does the reopened modal save the configuration on valid input?
• [ ] Does the reopened modal show the correct error on repeated invalid input?

[SafaiaArt]

• [x] Do config options with int/decimal values still save on valid input?
• [x] Does invalid input show the appropriate error for each data type?
• [x] Does clicking the button reopen the modal?
• [x] Does the reopened modal save the configuration on valid input?
• [x] Does the reopened modal show the correct error on repeated invalid input?

Yes to everything.

Note: For time based configurations (Raid Time, Lockdown Duration, etc), I think it would be good for the end user to know what the value translates to - whether it's seconds, minutes, hours etc.

[Tawmy]

Thanks for the QA!

Note: For time based configurations (Raid Time, Lockdown Duration, etc), I think it would be good for the end user to know what the value translates to - whether it's seconds, minutes, hours etc.

I agree, this will be added in #15.