search

TaxFoundation / capital-cost-recovery

Other
3 stars 3 forks source link

Update paths, add tests #8

Closed jdebacker closed 3 years ago

jdebacker commented 3 years ago

This PR updates the handling of file paths so that they work across operating systems and when files are run from source of from R Studio.

In addition, "expected" files are added to the repo. These, rather than the direct output files, are tracked. And tests were added to compare the files from a model run to those expected files so that the user can be sure they are getting the correct results.

jdebacker commented 3 years ago

The tests of model output that are added here help to check another box on the PSL Criteria Checklist.

The last commit updates the ../final-outputs-expected/cit_rates_timeseries.csv file. It seems that there was a minor change in the OECD data that was read in, which caused some differences in these results.

jdebacker commented 3 years ago

@elkeasen This PR is ready for your review.