Closed JBeresford closed 5 months ago
I asked a user to test and report it, but they disappeared (went silent):
it seemed to work for me, so merged.
If you have a working fix, why not submit a pull request?
Main reason for no PR was I away from my main machine over the weekend and GitHub mobile is awful for trying to do all the PR admin
Confirmation
The problem
Following the changes in #1757 pausing/stopping a media item in Plex doesn't stop the scrobble Trakt accordingly.
The issue seems to be stemming from the definition of the
scrobble_pause
method inplextraktsync/queue/TraktScrobbleWorker.py
The previous implementation called
scrobbler.pause(progress)
and did used to stop a scrobble when you stop media in Plex and it's below the watched threshold.However, completed watches in Plex do correctly fire the watched event. I'm assuming this is because the playback % is above the 90% I have defined in my config, so it fires scrobble_stop rather than scrobble_pause
Steps to reproduce the behavior
Error trace / logs
No response
Expected behavior
When pausing/stopping media in Plex that are below the "watched" threshold a scrobble pause event should be sent to Trakt.
Inspect of problematic items
No response
Workarounds
Downgrade to 0.28.12, which I've currently done for the container I run the watch command in as I don't like the 2nd workaround I found (which does seem to work)
Manually change the function definition in 0.28.15 using the files tabs on docker to:
Install method
docker-compose
Config file contents
Version
0.28.15
Python Version
3.12.1
Plex Server Version
1.32.8.7639-fb6452ebf
Operating System and Version
Windows 10