Compliance with PEP 517

[taconi]

The setuptools is treating setup.py as legacy after introducing pyproject.toml in PEP 517 and PEP 518.

[paxcoder]

there's a pull, but if the guy doesn't reply, we might need to fork off the project.

[taconi]

As long as pr is not accepted, installation can be done as follows:

pip>=23.1

pip install playsound@git+https://github.com/taconi/playsound

poetry>=1.5.0

poetry add playsound@git+https://github.com/taconi/playsound

[TaylorSMarks]

How backwards compatible is this?AFAIK, the current setup works in the latest version of Python and there’s no plans to ever break it. If they were to ever break it, I’d expect that to be in a Python 4 which is hopefully still far away.I believe playsound works all the way back to Windows XP on something like Python 2.3 (IDK, maybe it’s only up to 2.7). Although I’ve personally switched to exclusively using Python 3.7 and newer, I’d rather maintain compatibility with a much wider range if it’s not too difficult to do so.So… sell me on why this change is needed, beyond that it’s a newer thing that could be adopted. I could adopt f-strings in the project, too. I certainly like them on my projects where I don’t care about maintaining backwards compatibility. Type annotations are cool, too. I’d sooner adopt type annotations (as a quality measure), then switching to toml just for the sake of it.Sent from my iPhoneOn Nov 18, 2023, at 21:12, taconi @.> wrote: As long as the pr is not accepted, the installation can be done this way: pip install @.+https://github.com/taconi/playsound

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>

[taconi]

It would be more of a question of installation, in version 23.1 (2023-04-15) of pip support has been removed from setup.py:

Remove setup.py install fallback when building a wheel failed for projects without pyproject.toml. (#8368)

This version of pip only supports python >= 3.7 so <=3.6 would no longer be supported.

However, the latest versions of pip and poetry no longer support setup.py and currently python only supports versions >=3.8. I believe that the deprecated versions can be dropped as the <=1.3.0 version of playsound will continue to work for python <=3.6.

Can I add requires-python=">=3.7" in pyproject.toml in case of agreement @TaylorSMarks

[taconi]

I added requires-python=">=3.7" in pyproject.toml to make the required version explicit

[jessebot]

@TaylorSMarks are you still out there? This fix would make the lib more accessible to python poetry users.

[sjmikler]

This repository is not maintained anymore and didn't work as expected for me. I made a fork, refactored it and released to pip under the name playsound3.

See here: https://github.com/sjmikler/playsound3

[taconi]

Closed due to inactivity