search

Tazinho / Advanced-R-Solutions

Set of solutions for the Advanced R programming book
https://advanced-r-solutions.rbind.io/
290 stars 118 forks source link

Consistency in chapter 14 (R6 classes) #211

Closed its-gazza closed 4 years ago

its-gazza commented 4 years ago

e.g. BankAccount class does not write public explicitly but BankAccountStrct does.

I think it's better to explicitly write public = list() as users would then know which parameter is being used.

its-gazza commented 4 years ago

Sorry don't know how to do PR and link it to issue.

PR here: https://github.com/Tazinho/Advanced-R-Solutions/pull/212

henningsway commented 4 years ago

I like it and we'll merge it! Thank you so much. (: