search

TcMenu / tcMenuLib

TcMenu modular IoT menu library supporting rotary encoder, joysticks, many displays, and remote control over Ethernet and Serial
Apache License 2.0
111 stars 10 forks source link

Background color wrong after changing factory.setDrawingPropertiesForItem #190

Closed davetcc closed 1 year ago

davetcc commented 1 year ago

Describe the bug When display properties are overridden for the first item in the linked list, then the background after the last item is incorrectly set to the background of that item.

Confirm that the bug is in the embedded library Yes, it is in the embedded library, in the GraphicalDisplayRenderer

Commerical or personal/community use Commerical, davetcc

To Reproduce Simply override the first menu item in any sub menu or root.

Expected behavior The background should be the same as the rest of the menu.

Screenshots See https://github.com/davetcc/tcMenu/discussions/329 for screenshot and more detail.

Device Specs Affects all boards

Additional context N/A

davetcc commented 1 year ago

https://github.com/davetcc/tcMenu/issues/330

davetcc commented 1 year ago

I'm going to close this as fixed for now. Please reopen if the fix doesn't work as expected.