search

TcMenu / tcMenuLib

TcMenu modular IoT menu library supporting rotary encoder, joysticks, many displays, and remote control over Ethernet and Serial
Apache License 2.0
111 stars 10 forks source link

Two minor issues in menu manager #199

Closed davetcc closed 1 year ago

davetcc commented 1 year ago

Describe the bug

  1. Menu Manager does not send an end edit notification on runtime lists.
  2. Runtime list item does not have an edit end callback. There seems to be a bug in the list support that does not trigger an edit end callback.

Menu Item does not go into edit state properly after calling menuMgr.setCurrentEditor

Discussed in https://github.com/davetcc/tcMenu/discussions/346 See the discussion for context, but effectively the menu item passed to setCurrentEditor does not go into edit mode after calling the function.

Menu Item does not go into edit state properly after calling menuMgr.setCurrentEditor Discussed in https://github.com/davetcc/tcMenu/discussions/346. See the discussion for context, but effectively the menu item passed to setCurrentEditor does not go into edit mode after calling the function.

Confirm that the bug is in the embedded library embedded library

Commerical or personal/community use commercial - davetcc

To Reproduce simply call setCurrentEditor on any item and the number of entries will be wrong. Any list ending edit does not appear to run the commit hook.

Expected behavior menuMgr should behave as expected in both cases

Screenshots see discussion