TeKrop / overfast-api

⚡ Unofficial Overwatch 2 API, built with FastAPI, provides data on heroes, game modes, maps, and player careers
https://overfast-api.tekrop.fr
MIT License
95 stars 10 forks source link

feat: now building ngx_http_redis_module.so on nginx image build #137

Closed TeKrop closed 2 weeks ago

TeKrop commented 2 weeks ago

Instead of using already compiled ngx_http_redis_module.so file with nginx container, this PR aims to build the module on image build.

Several benefits :

Summary by Sourcery

This pull request modifies the nginx image build process to compile the ngx_http_redis_module.so module during the build, instead of using a pre-compiled version. This change removes the static module from the codebase, resolves issues on ARM-based machines, and facilitates easier nginx updates as long as the library remains compatible.

sourcery-ai[bot] commented 2 weeks ago

Reviewer's Guide by Sourcery

This pull request modifies the nginx image build process to compile the ngx_http_redis_module.so module during the image build instead of using a precompiled version. This change aims to remove the static module from the codebase, improve compatibility with ARM-based machines, and facilitate easier nginx updates.

File-Level Changes

Files Changes
docker-compose.yml Modified the healthcheck command to improve its efficiency and reliability.

Tips - Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request. - You can change your review settings at any time by accessing your [dashboard](https://sourcery.ai/dashboard): - Enable or disable the Sourcery-generated pull request summary or reviewer's guide; - Change the review language; - You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.
sonarcloud[bot] commented 2 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud