TeKrop / overfast-api

⚡ Unofficial Overwatch 2 API, built with FastAPI, provides data on heroes, game modes, maps, and player careers
https://overfast-api.tekrop.fr
MIT License
95 stars 10 forks source link

fix: fixed issue with roles endpoint since Blizzard update #145

Closed TeKrop closed 5 days ago

TeKrop commented 5 days ago

Summary by Sourcery

This pull request addresses a bug in the roles endpoint parser caused by recent updates to Blizzard's HTML structure. The HTML fixture for the home page has been updated to match the new structure, ensuring accurate parsing of roles data.

sourcery-ai[bot] commented 5 days ago

Reviewer's Guide by Sourcery

This pull request addresses the issue with the roles endpoint caused by Blizzard's recent update. The changes include updating the HTML structure in the test fixtures and simplifying the parsing logic in the roles parser to accommodate the new structure.

File-Level Changes

Files Changes
tests/fixtures/html/home.html
app/parsers/roles_parser.py
Updated HTML structure and parsing logic to align with Blizzard's recent changes to the roles endpoint.

Tips - Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request. - You can change your review settings at any time by accessing your [dashboard](https://app.sourcery.ai): - Enable or disable the Sourcery-generated pull request summary or reviewer's guide; - Change the review language; - You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.
sonarcloud[bot] commented 5 days ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud