search

TeKrop / overfast-api

⚡ Unofficial Overwatch 2 API, built with FastAPI, provides data on heroes, game modes, maps, and player careers
https://overfast-api.tekrop.fr
MIT License
102 stars 14 forks source link

feat: adding Blizzard ID to the search JSON #98

Closed MatthewSH closed 7 months ago

MatthewSH commented 7 months ago

As stated in #96, there's a new property on search. This will add it to the JSON from the search results.

This is a selfish addition as a way of preparing for the potential risk of them removing the automatic redirects from from the old URL format to the new format. This new property will allow us to capture the ID and start using that instead.

sonarcloud[bot] commented 7 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

TeKrop commented 7 months ago

Thank you ! I just updated the tests (still have to rework them in the future 🙈) and exposed "search player" model 👍

MatthewSH commented 7 months ago

Ahh thank you! Missed those models (don't work with python, I'm a NodeJS dev).