Fix #45. Move nyan-animation-timer control into nyan-mode function.

TeMPOraL / nyan-mode

Nyan Cat for Emacs! Nyanyanyanyanyanyanyanyanyan!

GNU General Public License v3.0

800 stars 67 forks source link

Fix #45. Move nyan-animation-timer control into nyan-mode function. #46

Closed tmurph closed 4 years ago

Zulu-Inuoe commented 4 years ago

Hey @TeMPOraL ! Any chance of merging this in? I just noticed this behaviour this morning and was about to open an issue and fork to PR, but it looks like @tmurph 's already done that work.

damon-kwok commented 4 years ago

@TeMpOraL @tmurph @Zulu-Inuoe This is really a Disaster. This change is estimated that countless users get an emacs startup error:

Symbol's function definition is void: nyan-start-animation.

You can use obsolete functions. See: https://www.gnu.org/software/emacs/manual/html_node/elisp/Obsolete-Functions.html

(defun nyan-start-animation() (message "nyan-start-animation is obsolete!")

TeMPOraL commented 4 years ago

Sorry. Didn't test it as thoroughly as I should have. Will fix in a moment.

TeMPOraL commented 4 years ago

Should be resolved now.

Zulu-Inuoe commented 4 years ago

Thank you! I'm sorry, I should have done my part in reviewing the changes rather than taking them for granted.

TeMPOraL commented 4 years ago

You're welcome! Don't worry. I should've tested before merging code in. Thanks @damon-kwok for reporting my mistake to me immediately, before a lot of people lost their favourite cat!