Closed mbrubeck closed 7 years ago
Pushed some minor stylistic fixes.
As an extra bonus, the sequence of operations in this version more closely resembles the C program, for anyone who wants to do side-by-side comparisons of the two.
This is brilliant, I'd love to see it merged!
I can't find a better explaination that what is already done. As Isaac closed the previous submission, do you prefer I submit or you submit?
And maybe we should wait some days on a bench without update before submitting it. That's too much update of the same bench for Isaac ;-)
As Isaac closed the previous submission, do you prefer I submit or you submit?
I'll create a new submission for this after it's stabilized for at least a couple of days.
I haven't come up with any new improvements and am no longer actively working on this benchmark, so I'll submit it later today if there are no other comments or changes posted.
OK for me, I'll merge when you provide the link to the submission.
Pushed my final version, which contains comment edits and a few minor style changes since the previous push.
This combines newline handling and the main "reverse complement" step into a single loop. The downside of this is that it can no longer treat the input as u16 in order to transform two bytes with one table lookup. The advantages are faster speed from making a single pass over the data, and no more unsafe code!
This runs about 18% faster than the master branch on my computer.