search

TeXitoi / structopt

Parse command line arguments by defining a struct.
Other
2.7k stars 149 forks source link

Replace proc-macro-error with proc-macro2-diagnostics #536

Open tamird opened 8 months ago

tamird commented 8 months ago

See individual commits.

I realize this crate is deprecated in favor of clap, but it still seems to enjoy some 10,000-40,000 downloads per day over the past three months. Updating to syn@2 is likely to have positive effect on compilation time for dependents.

See https://crates.io/crates/structopt-derive for download graphs.

tamird commented 5 months ago

@TeXitoi could you have a look please?

TeXitoi commented 5 months ago

That’s a big change for a frozen crate. I’ll try to have a look, but no promise.

epage commented 5 months ago

I realize this crate is deprecated in favor of clap, but it still seems to enjoy some 10,000-40,000 downloads per day over the past three months. Updating to syn@2 is likely to have positive effect on compilation time for dependents.

imo that effort would be better spent migrating some of the more popular users.

tamird commented 5 months ago

You mean like this? https://github.com/rust-lang/git2-rs/pull/1007 https://github.com/brendanzab/codespan/pull/357 https://github.com/marshallpierce/rust-base64/pull/262