search

TeaWithStrangers / tws-on-rails

Core Tea With Strangers application
http://teawithstrangers.com
25 stars 16 forks source link

Emails are still broken!! #529

Closed ankitshah811 closed 9 years ago

ankitshah811 commented 9 years ago

got this message from a host just now, but totally thought bug was fixed with yesterday's deployment. thoughts @mehulkar, @nickbarnwell ? image

mehulkar commented 9 years ago

probably because her reminders were queued before we deployed the fix

ankitshah811 commented 9 years ago

can we confirm this in logs? or at the least, confirm that we're not experiencing the same issues?

On Sat, Jul 11, 2015 at 4:13 PM, Mehul Kar notifications@github.com wrote:

probably because her reminders were queued before we deployed the fix

— Reply to this email directly or view it on GitHub https://github.com/TeaWithStrangers/tws-on-rails/issues/529#issuecomment-120668747 .

mehulkar commented 9 years ago

mayyy be able to look up things in logs. problem is that these events didn't all happen at the same time, so tracking down all the appropriate logs may or may not be possible.

Mehul Kar @mehulkar

On Mon, Jul 13, 2015 at 12:42 AM, Ankit Shah notifications@github.com wrote:

can we confirm this in logs? or at the least, confirm that we're not experiencing the same issues?

On Sat, Jul 11, 2015 at 4:13 PM, Mehul Kar notifications@github.com wrote:

probably because her reminders were queued before we deployed the fix

— Reply to this email directly or view it on GitHub < https://github.com/TeaWithStrangers/tws-on-rails/issues/529#issuecomment-120668747

.

— Reply to this email directly or view it on GitHub https://github.com/TeaWithStrangers/tws-on-rails/issues/529#issuecomment-120839743 .

kylechadha commented 9 years ago

I received ten "Mark your attendance" e-mails for a tea time I did last night. It was scheduled prior to the fix on Fri, but I guess the question is when the "Mark your attendance" e-mails are queued -- on event creation or occurrence.

@mehulkar let me know if there's anything I can look into or if you want specifics for the logs

mehulkar commented 9 years ago

@kylechadha there was a bug where we queued the "mark your attendance" reminder on every update to the tea time, so it would have queued the same email multiple times. That bug was fixed in #521, but it doesn't affect emails that were queued before because we didn't have any insight into queued jobs :cry: . I also deployed an admin interface for delayed jobs in #534 to help with that, but haven't actually looked at it yet. Not sure if it will help with old queued jobs anyway.

let me know if there's anything I can look into

lots you can look into! One thing is we need to change how we "queue" emails at certain times and instead run a cron job every night. Right now, if an email is queued, it gets queued and nothing can change it. So if you change the day/time of your teatime, the emails will be queued for the wrong times. That needs to be fixed.

mehulkar commented 9 years ago

Unrelated to emails, there are also a bunch of smaller bugs in the Issues list that you could look into.

mehulkar commented 9 years ago

this should be fixed now. see teawithstrangers.com/admin/jobs for more insight into jobs that were scheduled before this was fixed.