Closed markbao closed 6 years ago
@markbao Misc q's —
If a user is not signed in when they select a tea time, the tea time they selected will be saved in the session and they will be redirected to it after signup/login.
Assuming this directs to http://www.teawithstrangers.com/signup. If user clicks link to go to http://www.teawithstrangers.com/signin from that page, does the ?redirect_to
query hold? Or breaks
Users can select "Email me " on the /tea_times page.
Assuming this also redirects to Sign Up page?
Add city selector to signup page
At least, we want to wrap this selector in the drop down markdown/style used in settings page (see screenshot). If it's trivial, would love to use the Standard Select option here (https://harvesthq.github.io/chosen/) but with our styles.
Other:
"Sign up for a tea time" and "Join tea time" currently direct to home city page. Not sure what happens if no home city is selected. Regardless, these should point to /tea_times
(And later, this page should get a little more love because it is not very smartly designed)
Decide whether or not we want to remove city pages
Yes, remove them. Redirect all city page references to /tea_times
/tea_times/123 page should be redesigned.
Working on this now and will commit changes
/tea_times page needs additional styling.
WIP @me
Tea time list on host page: show only month, expand for future tea times?
Same logic as /tea_times
Determine what to do about next month's tea times (do we display them?)
Link to see next month's tea times. Will design into /tea_times
Determine if we need to change the tea times that city pages contain and any other changes to the other parts of the application.
Don't understand this. Can you clarify @markbao ?
Determine what to do about user profile pages for users who haven't set a home city (currently it's a big button that says "Set your home city" that goes to /cities)
Remove 'set home city' button. All CTAs should be to (1) register for tea time > (2) sign up so we can tell you about tea times next month
Determine if we show "past" tea times on /tea_times (probably not)
No. If I understand correctly, this PR is still showing past tea times, right? / This needs to be changed
Figure out what to do about the old user paths (e.g. what happens if they go directly to the signup page, sign up, and then select a home city, and go to their city page, etc.)
Redirect to /tea_times after signing up. Logging in should also redirect to /tea_times
Update 05/29/18:
New tea time page design TODO @markbao :
text-align:center; display: inline-block;
and anchor link each city name (see design at bottom)Ideal design for city anchor links:
To be done by AS 05/30/18:
/tea_times/123
page
readonly
form fields to make more obvious that they're un-editable/tea_times
/profile
for hosts (confusing atm, as we don't enforce this at all)@markbao TODO:
/tea_times/123
designtea_times/123
modalsNew commit 05/31/18 06:34 PM:
Incomplete /tea_times/123
page, but bulk of work done. Right 2/3 of the page will have a slightly modified host profile. Will attempt to build this out myself after 7:30pm PT. @markbao will message you if I am having trouble doing this alone.
Also I apologize for dirty SCSS and markup. Eventually this will be cleaned up. Rush job.
Note: @markbao I'm reasonably confident you can use this comment as a final to do list for the June push. Also, unless indicated otherwise, these are all assigned to you. @nickbarnwell It would be very helpful if you could review this PR as soon as possible, as it would be ideal to push changes by the EOD Friday 06/01/18
Email UI
tos.html.erb
and privacypolicy.html.erb
Tea time flow
/tea_times/123
pages/tea_times
page/tea_times/123
pages/tea_times
/tea_times
/tea_times/123
modals. Direct all links that triggered modals to the tea_times/123
page itself/signup
and /signin
to /tea_times
Double checking
/tea_times/123
) or styling /tea_times
)Notes
/tea_times
/tea_times
to host profile pagesTo do later (nonurgent)
Redesign the user flow so a listing of the month's tea times in all cities (at
/tea_times
) is the central place where people will interact with the application.Todo
/tea_times
page that displays tea times scheduled in the current month./tea_times
./tea_times
is publicly viewable, and the CTAs for signing up for tea times will go to signup/login pages if not logged in./tea_times
page.Waiting for
/tea_times/123
page should be redesigned./tea_times
page needs additional styling./cities
)/tea_times
(probably not)Copy (marked with
COPYTODO
)views/tea_times/index.html.erb
Stuff for the future