Fix cal events

[ankitshah811]

I've gotten word from several tea timers that the .ics file attachments have inconsistent discrepancies from the actual tea times. This is leading to lots of confusion.

I've seen from one group that the cal invite was set for 1hr earlier than tea time. I've seen from another that the cal invite was set for 30min later than tea time.

This is really important to sort out asap.

[nickbarnwell]

Without the matching files we can’t repro and we can’t fix. For example, given the code I don’t see how a 30m offset is even possible. We don’t have any host cities in fractional timezones... On 15 Jun 2014, at 18:07, ankitshah811 notifications@github.com wrote:

I've gotten word from several tea timers that the .ics file attachments have inconsistent discrepancies from the actual tea times. This is leading to lots of confusion.

I've seen from one group that the cal invite was set for 1hr earlier than tea time. I've seen from another that the cal invite was set for 30min later than tea time.

This is really important to sort out asap.

— Reply to this email directly or view it on GitHub.

[nickbarnwell]

The problem is in .friendly_time in the TeaTime model. The %l in strftime only has hour resolution; we need to add :%M if a time isn't precisely on the hour

[nickbarnwell]

Also, for the record, the ical events were always accurate. It was purely a display-layer issue. Surprisingly, this had absolutely nothing to do with TimeZone code!