search

TeachBooks / deploy-book-workflow

Reusable Actions workflow for TeachBooks/template
3 stars 0 forks source link

display code as multiline in preview of errors and warnings #29

Closed rlanzafame closed 5 months ago

rlanzafame commented 5 months ago

The error report is on multiline, but the summary only displays one line, making it difficult to read.

The example below shows how the copy/paste works fine to preserve newlines, but the markup display does not

example failed job

/home/runner/work/_temp/6b132ec8-1825-4122-af8b-89d07b523bdc.sh: /home/runner/work/exploratory_computing_with_python/exploratory_computing_with_python/.venv/bin/teachbooks: /home/runner/work/mbakker_exploratory_computing/mbakker_exploratory_computing/.venv/bin/python: bad interpreter: No such file or directory

image

rlanzafame commented 5 months ago

Ahhhhh, now i notice that the raw text that is copied has the newline, but it's only the GitHub markup that is not displaying properly. So my example above is flawed.

Anyway, maybe this is more trouble than it is worth (in which case perhaps a simple note of "copy/paste the error summary into a text editor to see line breaks" or something similar would be sufficient

Tom-van-Woudenberg commented 5 months ago

@rlanzafame The link to the action is pointing to the wrong action summary, I don't see the issue there. The error thing does support multiline errors. In your example the actual error is oneline in the GitHub 'CLI' itself. So I think we can close this one

Tom-van-Woudenberg commented 5 months ago

@rlanzafame The link to the action is pointing to the wrong action summary, I don't see the issue there. The error thing does support multiline errors. In your example the actual error is oneline in the GitHub 'CLI' itself. So I think we can close this one