TeachBooks / deploy-book-workflow

Reusable Actions workflow for TeachBooks/template
4 stars 0 forks source link

Add nice 404 page #45

Open Tom-van-Woudenberg opened 5 months ago

Tom-van-Woudenberg commented 5 months ago

To be compatible with: https://github.com/TeachBooks/deploy-book-workflow/pull/39 @severinbratus, am I correct that the current 404 page is described here: https://github.com/TeachBooks/deploy-book-workflow/blob/dc47d34ae3211fad64b30e55661162d923729551/.github/workflows/deploy-book.yml#L463 and that the current 404.html and 404.md can be deleted? Is it possible to use this default 404 page only if no custom 404 page is provided on the root of the repo to be in line with the github documentation?

severinbratus commented 5 months ago

Yes, that is correct. Yes, this should be possible. I see two tasks to do here:

AleksSliw commented 15 hours ago

I am editing the template for the generated 404 page and a question popped up. What should be the expected behaviour for 404 redirect? inputting a wrong URL in the form of valid-repository/wrong-name will redirect to valid-repository/main/wrong-name (which is still invalid and will show 404), while inputting valid-repository/right-branch/wrong-name will just show the 404 page with that same URL.

Im assuming the idea is to redirect to the main branch if the repository exists?

Tom-van-Woudenberg commented 15 hours ago

I think the 404 page should never redirect, only show a button to bring you to the root of valid-repository There'll always be a page on root.