Open christophscheuch opened 4 days ago
@t-emery I have prepared the packages for the initial CRAN submission, but you have to submit it as the maintainer. I suggest that you pull the status quo from the branch in the PR and review DESCRIPTION and README because I made a few changes: https://github.com/Teal-Insights/r-wbids/pull/38. In particular, I think it makes sense to describe the package as a stand-alone tool at the moment rather than relating it to packages that we are planing to release in the future.
Once you are ready to submit, please call devtools::submit_cran()
and then confirm the email that you receive. Afterwards, we keep the fingers crossed because some parts of the CRAN submission process are highly specific and can be missed even after thorough reviews and automatic checks 😄
Amazing!I’ll get this started today. Thanks for all of your awesome work on this!Sent from my iPhoneOn Nov 14, 2024, at 6:00 AM, Christoph Scheuch @.***> wrote: @t-emery I have prepared the packages for the initial CRAN submission, but you have to submit it as the maintainer. I suggest that you pull the status quo from the branch in the PR and review DESCRIPTION and README because I made a few changes: #38. In particular, I think it makes sense to describe the package as a stand-alone tool at the moment rather than relating it to packages that we are planing to release in the future. Once you are ready to submit, please call devtools::submit_cran() and then confirm the email that you receive. Afterwards, we keep the fingers crossed because some parts of the CRAN submission process are highly specific and can be missed even after thorough reviews and automatic checks 😄
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>
I'll close the issue once the package is available on CRAN and the other to-do's in the first comment can be done :)
EDIT: ah I just saw that you merged the PR. In the future, we should submit from the release branch and merge the PR once CRAN has accepted the submission.
I'll close the issue once the package is available on CRAN and the other to-do's in the first comment can be done :)
EDIT: ah I just saw that you merged the PR. In the future, we should submit from the release branch and merge the PR once CRAN has accepted the submission.
Sorry about that; my fault. I will document the release workflow so we know how to do it in the future. I appreciate your detailed checklist above.
Sorry about that; my fault. I will document the release workflow so we know how to do it in the future. I appreciate your detailed checklist above.
The checklist is the outcome of the single line that I already added to the release workflow here 😁 https://github.com/Teal-Insights/r-wbids/wiki/Development-Workflow#cran-releases
I decided to exclude both
econid
andwbwdi
for the initial release. Both should be on CRAN if they are included in any way in the DESCRIPTION file.econid
still needs some time to mature for a CRAN release.wbwdi
should be released jointly with other stuff that provide more justification for a new WDI package.First release:
usethis::use_news_md()
usethis::use_cran_comments()
Title:
andDescription:
@return
and@examples
Authors@R:
includes a copyright holder (role 'cph')Prepare for release:
git pull
usethis::use_github_links()
urlchecker::url_check(parallel = FALSE)
devtools::build_readme()
devtools::check(remote = TRUE, manual = TRUE)
devtools::check_win_devel()
git push
Draft blog postSubmit to CRAN:
usethis::use_version('minor')
devtools::submit_cran()
Wait for CRAN...
Finish & publish blog postAdd link to blog post in pkgdown news menuusethis::use_github_release()
usethis::use_dev_version(push = TRUE)
usethis::use_news_md()