search

Team-4536 / Command-Based-2015

0 stars 0 forks source link

inefficient limit method #1

Closed inkling16 closed 9 years ago

inkling16 commented 9 years ago

Utilities limit(double input , double lowerBound, double upperBound) method: Use "return" instead of "="

stepansubbotin commented 9 years ago

I believe I solved this in commit ac1d7e9. You can close the issue if I did.

inkling16 commented 9 years ago

I received an email 20 minutes ago saying:

"I believe I solved this in commit ac1d7e9 https://github.com/Team-4536/Command-Based-2015/commit/ac1d7e9ac64760d22b85784625782287ca725c0e. You can close the issue if I did."

On Mon, Jun 29, 2015 at 12:04 PM, Stepan Subbotin notifications@github.com wrote:

Do you guys get emails when I comment on issues? If not, I commented on the issue.

On Mon, Jun 29, 2015 at 10:13 AM, Caleb Sykes notifications@github.com wrote:

Utilities lines 16 and 19: Use return instead of =

— Reply to this email directly or view it on GitHub https://github.com/Team-4536/Command-Based-2015/issues/1.

— Reply to this email directly or view it on GitHub https://github.com/Team-4536/Command-Based-2015/issues/1#issuecomment-116762452 .

inkling16 commented 9 years ago

Whoa, my email response is on github now.

On Mon, Jun 29, 2015 at 12:16 PM, Caleb Sykes calebsyk@gmail.com wrote:

I received an email 20 minutes ago saying:

"I believe I solved this in commit ac1d7e9 https://github.com/Team-4536/Command-Based-2015/commit/ac1d7e9ac64760d22b85784625782287ca725c0e. You can close the issue if I did."

On Mon, Jun 29, 2015 at 12:04 PM, Stepan Subbotin < notifications@github.com> wrote:

Do you guys get emails when I comment on issues? If not, I commented on the issue.

On Mon, Jun 29, 2015 at 10:13 AM, Caleb Sykes notifications@github.com wrote:

Utilities lines 16 and 19: Use return instead of =

— Reply to this email directly or view it on GitHub https://github.com/Team-4536/Command-Based-2015/issues/1.

— Reply to this email directly or view it on GitHub https://github.com/Team-4536/Command-Based-2015/issues/1#issuecomment-116762452 .

stepansubbotin commented 9 years ago

Should we close the issue then?

inkling16 commented 9 years ago

Yes, it's all good