search

Team-Eidolon / eidolon

Spooky Minecraft mod.
BSD 3-Clause "New" or "Revised" License
3 stars 5 forks source link

Clicking on different tabs of the book causes a client crash #29

Open thedeerirty opened 1 year ago

thedeerirty commented 1 year ago

Not sure if this is an incompatibility - I imagine it is, but rather I'm not sure with what crash-2023-09-23_23.22.18-client.txt

QinomeD commented 1 year ago

Yeah it's incompatible with immediately fast, it's already known

RaphiMC commented 1 year ago

This is caused by the wrong usage of MultiBufferSource. You are supposed to create one (Passing the Tesselator buffer) and store a reference to it, then call some methods which render into it and then draw the buffer source (Not the Tesselator). Calling tess.end() here (https://github.com/Team-Eidolon/eidolon/blob/1.19.x/src/main/java/elucent/eidolon/codex/EntityPage.java#L48) is just wrong and causes some data to be discarded instead of being drawn. And in the case of IF it causes a crash since IF never uses/begins the Tesselator buffer that was passed as argument