Team-EnderIO / EnderIO

EnderIO Rewritten for Modern Minecraft.
https://enderio.com
The Unlicense
328 stars 95 forks source link

[1.20.1] Crash when using a fluid conduit on a GT pipe #641

Closed Leclowndu93150 closed 6 months ago

Leclowndu93150 commented 6 months ago

Is there an existing issue for this?

Current Behavior

Crash when getting fluid from a GT pipe using enderio conduits

Expected Behavior

work

How to Test

No response

Local Environment

https://gist.github.com/Leclowndu93150/3ebd643201fc9e50358f1e3c37a56bad it's all here

Any Additional Information?

No response

Leclowndu93150 commented 6 months ago

image

ferriarnus commented 6 months ago

Try first without connector. If the issue stays present can you upload the new log without connector.

Leclowndu93150 commented 6 months ago

image are you glad now ?

Leclowndu93150 commented 6 months ago

i don't get how tf Connector would affect anything between these 2 mods

crash-2024-03-25_10.14.46-server.txt

ferriarnus commented 6 months ago

Connector is a mod that makes fabric run on forge. It is know to have issues, especially with bigger mods that use a lot of the forge api. As a rule of thumb, we always want the minimal test case to rule out interactions from other mods (so to verify it's really enderio and gregtech, not another 3rd mod playing a rol). Since the issue exists without connector, we will look further into it. On a first glance, gregtech returns "null" for a fluid stack which doesn't seem proper, as an empty fluidstack is represented by the EMPTY object.

screret commented 6 months ago

where do we exactly return a null fluidstack?

screret commented 6 months ago

oh, hm I might? see what you mean

screret commented 6 months ago

whoop-de-doop found the issue

screret commented 6 months ago

https://github.com/GregTechCEu/GregTech-Modern/pull/1010 feel free to close this.

ferriarnus commented 6 months ago

Oh good you found it so quick! Closing it as completed.