Open walguru opened 2 months ago
Caused by: java.lang.NullPointerException: Cannot invoke "com.google.gson.JsonElement.getAsString()" because the return value of "com.google.gson.JsonObject.get(String)" is null at com.enderio.machines.common.recipe.TankRecipe$Serializer.fromJson(TankRecipe.java:126) ~[EnderIO-1.20.1-6.0.25-alpha.jar%23828!/:6.0.25-alpha] at com.enderio.machines.common.recipe.TankRecipe$Serializer.m6729(TankRecipe.java:116) ~[EnderIO-1.20.1-6.0.25-alpha.jar%23828!/:6.0.25-alpha]
important stuff
I don't think this is caused by Ender IO itself, but potentially by a wrongly written KubeJS or JSON recipe. In any case we should certainly be catching this and logging the error rather than crashing the game.
Uh oh
Resolved in upstream now, however I'd like to see us catch exceptions rather than break games.
Thanks for addressing this so quickly though!
Is there an existing issue for this?
Current Behavior
The world is not loading because of a message. "Errors in currently selected data packs prevented the world from loading
Expected Behavior
The world to load without an error
How to Test
open/ create a world
Local Environment
Any Additional Information?
[02May2024 15:03:33.917] [Render thread/WARN] [net.minecraft.client.gui.screens.worldselection.WorldOpenFlows/]: Failed to load level data or datapacks, can't proceed with server load java.util.concurrent.ExecutionException: java.lang.NullPointerException: Cannot invoke "com.google.gson.JsonElement.getAsString()" because the return value of "com.google.gson.JsonObject.get(String)" is null at java.util.concurrent.CompletableFuture.reportGet(CompletableFuture.java:396) ~[?:?] at java.util.concurrent.CompletableFuture.get(CompletableFuture.java:2073) ~[?:?] at net.minecraft.client.gui.screens.worldselection.WorldOpenFlows.m246486(WorldOpenFlows.java:164) ~[client-1.20.1-20230612.114412-srg.jar%231166!/:?] at net.minecraft.client.gui.screens.worldselection.WorldOpenFlows.m233122(WorldOpenFlows.java:113) ~[client-1.20.1-20230612.114412-srg.jar%231166!/:?] at net.minecraft.client.gui.screens.worldselection.WorldOpenFlows.doLoadLevel(WorldOpenFlows.java:181) ~[client-1.20.1-20230612.114412-srg.jar%231166!/:?] at net.minecraft.client.gui.screens.worldselection.WorldOpenFlows.m233145(WorldOpenFlows.java:169) ~[client-1.20.1-20230612.114412-srg.jar%231166!/:?] at net.minecraft.client.gui.screens.worldselection.WorldOpenFlows.handler$ggg000$onLoadLevel(WorldOpenFlows.java:2032) ~[client-1.20.1-20230612.114412-srg.jar%231166!/:?] at net.minecraft.client.gui.screens.worldselection.WorldOpenFlows.m233133(WorldOpenFlows.java) ~[client-1.20.1-20230612.114412-srg.jar%231166!/:?] at net.minecraft.client.gui.screens.worldselection.WorldSelectionList$WorldListEntry.m101744(WorldSelectionList.java:575) ~[client-1.20.1-20230612.114412-srg.jar%231166!/:?] at net.minecraft.client.gui.screens.worldselection.WorldSelectionList$WorldListEntry.m101704(WorldSelectionList.java:474) ~[client-1.20.1-20230612.114412-srg.jar%231166!/:?] at net.minecraft.client.gui.screens.worldselection.WorldSelectionList$WorldListEntry.m6375(WorldSelectionList.java:413) ~[client-1.20.1-20230612.114412-srg.jar%231166!/:?] at net.minecraft.client.gui.components.AbstractSelectionList.m6375(AbstractSelectionList.java:298) ~[client-1.20.1-20230612.114412-srg.jar%231166!/:?] at net.minecraft.client.gui.components.events.ContainerEventHandler.m6375(ContainerEventHandler.java:38) ~[client-1.20.1-20230612.114412-srg.jar%231166!/:?] at net.minecraft.client.MouseHandler.m168084(MouseHandler.java:92) ~[client-1.20.1-20230612.114412-srg.jar%231166!/:?] at net.minecraft.client.gui.screens.Screen.m96579(Screen.java:437) ~[client-1.20.1-20230612.114412-srg.jar%231166!/:?] at net.minecraft.client.MouseHandler.m91530(MouseHandler.java:89) ~[client-1.20.1-20230612.114412-srg.jar%231166!/:?] at net.minecraft.client.MouseHandler.m168091(MouseHandler.java:189) ~[client-1.20.1-20230612.114412-srg.jar%231166!/:?] at net.minecraft.util.thread.BlockableEventLoop.execute(BlockableEventLoop.java:102) ~[client-1.20.1-20230612.114412-srg.jar%231166!/:?] at net.minecraft.client.MouseHandler.m91565(MouseHandler.java:188) ~[client-1.20.1-20230612.114412-srg.jar%231166!/:?] at org.lwjgl.glfw.GLFWMouseButtonCallbackI.callback(GLFWMouseButtonCallbackI.java:43) ~[lwjgl-glfw-3.3.1.jar%23141!/:build 7] at org.lwjgl.system.JNI.invokeV(Native Method) ~[lwjgl-3.3.1.jar%23153!/:build 7] at org.lwjgl.glfw.GLFW.glfwWaitEventsTimeout(GLFW.java:3474) ~[lwjgl-glfw-3.3.1.jar%23141!/:build 7] at com.mojang.blaze3d.systems.RenderSystem.limitDisplayFPS(RenderSystem.java:237) ~[client-1.20.1-20230612.114412-srg.jar%231166!/:?] at net.minecraft.client.Minecraft.m91383(Minecraft.java:1173) ~[client-1.20.1-20230612.114412-srg.jar%231166!/:?] at net.minecraft.client.Minecraft.m91374(Minecraft.java:718) ~[client-1.20.1-20230612.114412-srg.jar%231166!/:?] at net.minecraft.client.main.Main.main(Main.java:218) ~[1.20.1-forge-47.2.30.jar:?] at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?] at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) ~[?:?] at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?] at java.lang.reflect.Method.invoke(Method.java:568) ~[?:?] at net.minecraftforge.fml.loading.targets.CommonLaunchHandler.runTarget(CommonLaunchHandler.java:111) ~[fmlloader-1.20.1-47.2.30.jar:?] at net.minecraftforge.fml.loading.targets.CommonLaunchHandler.clientService(CommonLaunchHandler.java:99) ~[fmlloader-1.20.1-47.2.30.jar:?] at net.minecraftforge.fml.loading.targets.CommonClientLaunchHandler.lambda$makeService$0(CommonClientLaunchHandler.java:25) ~[fmlloader-1.20.1-47.2.30.jar:?] at cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:30) ~[modlauncher-10.0.9.jar:?] at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:53) ~[modlauncher-10.0.9.jar:?] at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:71) ~[modlauncher-10.0.9.jar:?] at cpw.mods.modlauncher.Launcher.run(Launcher.java:108) ~[modlauncher-10.0.9.jar:?] at cpw.mods.modlauncher.Launcher.main(Launcher.java:78) ~[modlauncher-10.0.9.jar:?] at cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:26) ~[modlauncher-10.0.9.jar:?] at cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:23) ~[modlauncher-10.0.9.jar:?] at cpw.mods.bootstraplauncher.BootstrapLauncher.main(BootstrapLauncher.java:141) ~[bootstraplauncher-1.1.2.jar:?] Caused by: java.lang.NullPointerException: Cannot invoke "com.google.gson.JsonElement.getAsString()" because the return value of "com.google.gson.JsonObject.get(String)" is null at com.enderio.machines.common.recipe.TankRecipe$Serializer.fromJson(TankRecipe.java:126) ~[EnderIO-1.20.1-6.0.25-alpha.jar%23828!/:6.0.25-alpha] at com.enderio.machines.common.recipe.TankRecipe$Serializer.m6729(TankRecipe.java:116) ~[EnderIO-1.20.1-6.0.25-alpha.jar%23828!/:6.0.25-alpha] at net.minecraftforge.common.extensions.IForgeRecipeSerializer.fromJson(IForgeRecipeSerializer.java:23) ~[forge-1.20.1-47.2.30-universal.jar%231171!/:?] at net.minecraft.world.item.crafting.RecipeManager.fromJson(RecipeManager.java:171) ~[client-1.20.1-20230612.114412-srg.jar%231166!/:?] at net.minecraft.world.item.crafting.RecipeManager.m5787(RecipeManager.java:67) ~[client-1.20.1-20230612.114412-srg.jar%231166!/:?] at net.minecraft.world.item.crafting.RecipeManager.m5787(RecipeManager.java:34) ~[client-1.20.1-20230612.114412-srg.jar%231166!/:?] at net.minecraft.server.packs.resources.SimplePreparableReloadListener.m10789(SimplePreparableReloadListener.java:13) ~[client-1.20.1-20230612.114412-srg.jar%231166!/:?] at java.util.concurrent.CompletableFuture$UniAccept.tryFire(CompletableFuture.java:718) ~[?:?] at java.util.concurrent.CompletableFuture$Completion.run(CompletableFuture.java:482) ~[?:?] at net.minecraft.server.packs.resources.SimpleReloadInstance.m143940(SimpleReloadInstance.java:69) ~[client-1.20.1-20230612.114412-srg.jar%231166!/:?] at net.minecraft.util.thread.BlockableEventLoop.m6367(BlockableEventLoop.java:156) ~[client-1.20.1-20230612.114412-srg.jar%231166!/:?] at net.minecraft.util.thread.ReentrantBlockableEventLoop.m6367(ReentrantBlockableEventLoop.java:23) ~[client-1.20.1-20230612.114412-srg.jar%231166!/:?] at net.minecraft.util.thread.BlockableEventLoop.m7245(BlockableEventLoop.java:130) ~[client-1.20.1-20230612.114412-srg.jar%231166!/:?] at net.minecraft.util.thread.BlockableEventLoop.m18701(BlockableEventLoop.java:139) ~[client-1.20.1-20230612.114412-srg.jar%231166!/:?] at net.minecraft.client.Minecraft.m18701(Minecraft.java:5441) ~[client-1.20.1-20230612.114412-srg.jar%231166!/:?] at net.minecraft.client.gui.screens.worldselection.WorldOpenFlows.m246486(WorldOpenFlows.java:163) ~[client-1.20.1-20230612.114412-srg.jar%231166!/:?] ... 38 more