Team-EnderIO / EnderIO

EnderIO Rewritten for Modern Minecraft.
https://enderio.com
The Unlicense
332 stars 100 forks source link

Conduit upgrade void #691

Closed ferriarnus closed 3 months ago

ferriarnus commented 3 months ago

Description

Currently, if adding a conduit fails it still runs the vanilla place code that consumes the stack. This is fixed here by returning "FAIL" when the conduit can not be added.

This methods use of optional is unclear to me, maybe a simple null is better?

fixes: #669

TODO

Breaking Changes

List any breaking changes in this section, such as: changed/removed APIs, changed or removed items/blocks or modifications to recipes and gameplay mechanics.

Checklist