Team-EnderIO / EnderIO

EnderIO Rewritten for Modern Minecraft.
https://enderio.com
The Unlicense
327 stars 94 forks source link

Ender IO crafter crashes server if an item requires methods to be called as part of its recipe #743

Open melerva opened 1 month ago

melerva commented 1 month ago

Is there an existing issue for this?

Current Behavior

When an item with special code is added to an autocrafter, the crafter attempts to run the method, then crashes when the method fails. Specifically, the speedloader from Immersive Engineering: https://github.com/BluSunrize/ImmersiveEngineering/issues/6021

Expected Behavior

I would recommend checking for exceptions in the crafter and simply destroying the block or removing the item from its configuration if something goes wrong. That would be the simplest way to fix it.

How to Test

  1. place a crafter down
  2. set the outer slots to Immersive Engineering cartridges
  3. set the middle slot to an Immersive Engineering speedloader
  4. the server crashes the very next tick, and will not come back up as long as the tile entity exists

Local Environment

- **Operating System**: Debian
- **Java version**: 17.0.11
- **Minecraft Version**: 1.20.1
- **Version**: 6.1.6
- **Other Mods**: Immersive Engineering

Any Additional Information?

No response

CitiesXL2815 commented 1 month ago

pls provide us with Crash Log, with using this mod for server https://www.curseforge.com/minecraft/mc-mods/fullstack-watchdog let it crash again, Do note IE isn't supported on 1.20.1 anymore

melerva commented 1 month ago

Interesting. It's not crashing with that mod installed... nope there it went again

melerva commented 1 month ago

Here you go: https://gist.github.com/melerva/22d8c15e61de39793d75afec95a50966

Rover656 commented 1 month ago

This is an Ender IO bug by initial look - we're not providing the correct inventory contents to their recipe and are causing a null reference exception in their recipe. This will be a bug that affects both 1.21 and 1.20.1 - as such I'm marking this higher on our list.

Thank you for reporting!