Team-EnderIO / EnderIO

EnderIO Rewritten for Modern Minecraft.
https://enderio.com
The Unlicense
341 stars 107 forks source link

Filters void items and may crash server #834

Closed Beni10PT closed 2 weeks ago

Beni10PT commented 1 month ago

Is there an existing issue for this?

Current Behavior

When trying to create a filter the slots of the filter use the item provided, then when you try and remove the item from the filter slot it may or may not remove the item and can stay as an empty slot and the item is voided. It can then result in a server crash.

Logs: https://mclo.gs/LR00PPA

Expected Behavior

How to Test

  1. Craft handful of basic filters
  2. Have random objects to insert on the filter on your inventory
  3. On your hand use the basic filters in the air ( open interface )
  4. Place each of your random items in the slots.
  5. Items are physically placed in the filter
  6. Split the basic filter stack in 2
  7. Try and remove the items from 1 of the stacks by opening the interface
  8. Sometimes the item is retrieved sometimes voided.

Local Environment

- **Operating System**: Exaroton Server with 4GB 2 Cores ATM10 Modpack v0.60
- **Java version**: 17?
- **Minecraft Version**: 1.21.1
- **Version**: 7.0.5-alpha
- **Other Mods**: Applied Energistics 2, Mekanism...

Any Additional Information?

No response

ferriarnus commented 1 month ago

can you please fill in the version information?

Beni10PT commented 1 month ago

Done

Rover656 commented 1 month ago

Okay I'm struggling to see the cause of your crash (not what is wrong code-wise but how you got there). Do you have control over the server at all? It might be a case that the next version of Ender IO may fix all the issues here (except JEI dragging, I'll need to look into that).

Beni10PT commented 1 month ago

I am on the ATM10 modpack, changing the version would be not an option since many of the players would have to manually change it too, I want to believe this happened because of low server TPS at the time of the issue.

Rover656 commented 1 month ago

Well I think we will need to wait until we release the next build of Ender IO and for ATM10 to pick it up in that case - it's quite probable that this bug has been fixed in dev. I'll try to keep an eye out for when this happens and will comment again, but please bump if its been a while without comment. Thanks!

Rover656 commented 1 month ago

Ender IO 7.0.7-alpha has released with the fixes I mentioned. Once ATM10 picks up this update, please try and see if this still occurs. Thanks!

Rover656 commented 2 weeks ago

Closing as we've not received a response. Please open a new issue if this happens again.