search

Team-Half-and-Half / spirebooks

A financial projection and management decision tool made for Spire Hawaii.
MIT License
0 stars 0 forks source link

Review: 10 ImportFunctions.js and AuditedBalanceImportFunc.js #162

Open caspascual opened 4 hours ago

caspascual commented 4 hours ago

Overview

Please pay attention too:

Review Branch

review-10

Files to review

Checklists

Due date

Monday, 11/18/2024

For more information

The review process is documented at: http://courses.ics.hawaii.edu/ics414s21/morea/review/reading-idpm-review.html

caspascual commented 3 hours ago

ImportFunctions.js

L51-59: Design-02: Can we remove the nested if blocks?

AuditedBalanceImportFunc.js

JS-07: Remove all console logs

JS-03: Can spread be used to make it cleaner?

samallari commented 3 hours ago

ImportFunction.js

AuditedBalanceImportFunc.js

t-tirabassi commented 2 hours ago

ImportFunctions.js:

Design-05: A lot of the comments detailing the code can be removed since much of it is self-explanatory.

AuditedBalanceImportFunc.js:

JS-07: Remove the console.log statements.

JS-01: The export auditedBalanceImport should be renamed to auditedBalanceImportFunc so that it matches the file name.