Review 2: ImportSheet.jsx and Landing.jsx

Team-Half-and-Half / spirebooks

MIT License

0 stars 0 forks source link

Review 2: ImportSheet.jsx and Landing.jsx #68

Open beydlern opened 3 days ago

beydlern commented 3 days ago

Overview

Please pay attention too:

Javascript issues
React components

Review Branch

review-2

Files to review

ImportSheet.jsx
Landing.jsx

Checklists

Architecture
Design
JS
React

Due date

Monday, 9/23/2024

For more information

The review process is documented at: http://courses.ics.hawaii.edu/ics414s21/morea/review/reading-idpm-review.html

t-tirabassi commented 3 days ago

ImportSheet.jsx:

Design-07: Minor comments could be added to explain lines 15 and 29 to ensure readability

React-01: The file upload on line 34 and the data display on lines 35-40 could be made into smaller components that way they can be isolated and imported into the ImportSheet page

Landing.jsx:

Design-07: The different sections could be split up into subcomponents for better organization

JS-04: Some of the repeating classNames could be condensed into a CSS class