[Bug]: Crate opening animation is slightly slower than closing animation - Githubissues

Team-Immersive-Intelligence / ImmersiveIntelligence

An addon for Immersive Engineering focused on Electronics, Warfare, Logistics and Intelligence

https://www.iiteam.net/

Other

92 stars 40 forks source link

[Bug]: Crate opening animation is slightly slower than closing animation #376

Closed LolscopeDev2022 closed 14 hours ago

LolscopeDev2022 commented 4 days ago

Initial Check

[X] I have checked the existing issues and this one is not a duplicate

Category

🧊Rendering

Description

Exactly what title says. THOUGH, it might be just me.

Side

Client

Reproduction

Open the ammo/medical/repair crate by RMB+Shift

Expected Behaviour

Timing of the animations should be equal in both opening and closing

Logs

No response

Other Evidence

No response

Operating System

Linux

Minecraft Version

1.12.2

Immersive Intelligence Version

0.3.1-dev2

Immersive Engineering Version

0.98

Avalon2106 commented 2 days ago

How much slower is it? If its massive, we should fix it, otherwise its probably minor enough just to leave it and close the issue

Pabilo8 commented 2 days ago

This is intended, https://github.com/Team-Immersive-Intelligence/ImmersiveIntelligence/blob/5ab746758b5bb6289e83cbc1ec7d10ad97cb595d/src/main/java/pl/pabilo8/immersiveintelligence/client/render/metal_device/EffectCrateRenderer.java#L35 @Avalon2106 instead of altering the speed, rewrite this line to use getAnimationProgress method from IIAnimationUtils.