Team-Isaac-Polito / reseq_ros2

High-level ROS2 code to control the ReseQ robot
GNU General Public License v3.0
0 stars 0 forks source link

Rethink handling of parameters #3

Closed marc0777 closed 1 year ago

marc0777 commented 1 year ago

Currently parameters are handled by opening a yaml file directly in the node that require it. However this doesn't allow a simple way to share parameters across different nodes.

One way to solve this could be to use ROS parameters, and populate them either by a node reading the yaml file and publishing them, or having them defined in different launch file, one for each configuration.

marc0777 commented 1 year ago

Closed by https://github.com/Team-Isaac-Polito/reseq_ros2/commit/c1b783ce3e7e75708950b139b8908735f5ca0912 and https://github.com/Team-Isaac-Polito/reseq_ros2/commit/68d7b089b3346729af0ca5da790c3e663b7012c5, that replaced the hand passed yaml file with ROS parameters.