Team-JSB / MusicBot

:musical_note: MusicBot for Discord (Just-Some-Bots/MusicBot), but regularly maintained.
https://team-jsb.github.io/MusicBot/
MIT License
10 stars 5 forks source link

[Feature request] Clean up bot embeds #8

Open Soitora opened 4 years ago

Soitora commented 4 years ago

Please tick all applicable boxes.

Which version are you using?

What type of issue are you creating?


Description of request

Current embeds look technical and ugly, I propose they get cleaned up a little.

Examples

I made a quick embed (using Nadeko embed page) which looks something like this: image

Instead of the current which looks kind of like this (except this screenshot has no queue position): image Regarding even the remade embed, I don't think the bot name and the Play sections are needed, they just bloat it needlessly image


Something similiar could be made for all the commands and would significantly increase the look and feel of the bot, I think primarily using code markdown for marking text is quite bad looking as well.

Exit words

Thanks for keeping the project going, real happy to see updates coming, huge kudos! Sincerely, Soitora

TheerapakG commented 4 years ago

Currently, embed support in the bot's main version is rather poor. If command wants to return embed with more than one field then that embed needs to be generated "manually" for that. cogs-rewrite's send message could be backported for this as it can generate embed from the supplied dict based on template. Then, not showing the bot name and the command in the title could be options to exclude them from the template instead.

However, there are things on that branch that need some cleanup so I would attend to those things first then come back around for this.

On another note, I appreciate that you seem to be cultured as well ( ̄ー ̄), though I watch kaichou and mad rabbit (AH↓ HA↑ HA↑ HA↑) more often than this kitsuneko.

Soitora commented 4 years ago

Currently, embed support in the bot's main version is rather poor. If command wants to return embed with more than one field then that embed needs to be generated "manually" for that. cogs-rewrite's send message could be backported for this as it can generate embed from the supplied dict based on template. Then, not showing the bot name and the command in the title could be options to exclude them from the template instead.

However, there are things on that branch that need some cleanup so I would attend to those things first then come back around for this.

Alright cheers, looking forward to future updates :)

On another note, I appreciate that you seem to be cultured as well ( ̄ー ̄), though I watch kaichou and mad rabbit (AH↓ HA↑ HA↑ HA↑) more often than this kitsuneko.

😏😏