Team-OKC-Robotics / FRC-2022-CPP

a c++ port of our FRC-2022 code as training in C++
Other
0 stars 2 forks source link

Port intake commands #29

Closed jkleiber closed 1 year ago

jkleiber commented 1 year ago

Summary Most of the intake port is done, but we need to port the commands from the intake to C++

Work to Do

Verification

danielbrownmsm commented 1 year ago

Do we need to add unit tests for the intake commands? Or is it not important to test commands, as everything should be covered with just testing the underlying subsystem? I guess that's a question for everything, not just the intake.

jkleiber commented 1 year ago

The unit tests themselves verify that the subsystem functions behave as expected. Unit tests aren't a great fit for commands because commands are more about how the robot behaves in real time. Automated simulation tests would be more appropriate for testing commands, but that will take some work to figure out