Team-OKC-Robotics / FRC-2023

The FRC team #2718 Team OKC Robotics code for the 2023 season
Other
2 stars 0 forks source link

Add commands to the Arm subsystem #14

Closed jkleiber closed 1 year ago

jkleiber commented 1 year ago

Summary We need some commands in the Arm subsystem in order to use it in teleop/auto. It would be most beneficial if we create public functions in the subsystem that are used by commands to set the action we want the subsystem to take. Then in Periodic we can use some private functions as appropriate to execute the desired commands.

Here's an example of the framework for a generic subsystem:

// Note: this is public in the header file
bool Subsystem::SetPosition(const double &position) {
    this.position_ = position;
    return true;
}

void Subsystem::Periodic() { 
    // The subsystem does different things based on what mode it is put in by the user.
    switch(mode) {
        case Manual:
            OKC_CALL(SetUserPower());
            break;
        case AutoPosition: 
           OKC_CALL(GoToPosition());
            break;
        default:
             break;
    }
}

// Note: these are private in the header file:
bool Subsystem::SetUserPower() {
    // OKC_CHECKs as needed

    // Set the user power
    interface_.power = power;

    return true;
}

bool Subsystem::GoToPosition() {
    // OKC_CHECKs as needed

    // Control the position using PID

    return true;
}

Work

Verification

AbbeySieg commented 1 year ago

Here is a list of proposed commands: -SetArmExtension -SetArmAngle -IncrementArmPresetPosition (tele-op)