Team-OKC-Robotics / FRC-2023

The FRC team #2718 Team OKC Robotics code for the 2023 season
Other
2 stars 0 forks source link

Add parameters for hardware configuration to TOML file #22

Open jkleiber opened 1 year ago

jkleiber commented 1 year ago

Summary Hardware configurations and limits need to be added to the parameters.toml file.

Items to add:

Work

Verification

Deferred Work Adding the following is deferred until we can figure out how to integrate parameter loading in CI:

jkleiber commented 1 year ago

@AbbeySieg what's the status on this? Do you feel like you can take this task on? I'll assign it to you for now

AbbeySieg commented 1 year ago

I'm not sure if Daniel or Noah updated you, but the unit tests for the arm were not pulling the PID values from the parameters.toml file. We figured out how to make the unit tests pass. As long as someone tells me what to for this task I am able to do it.

jkleiber commented 1 year ago

@danielbrownmsm @noahzemlin @AbbeySieg the parameters not being pulled is a known issue (by me at least) from the beta test. The issue is that the deploy directory doesn't get copied to the unit test execution location. I had some hacks on the beta repo to fix this, but I would recommend disabling such unit tests or setting appropriate default values