search

Team-OKC-Robotics / FRC-2023

The FRC team #2718 Team OKC Robotics code for the 2023 season
Other
2 stars 0 forks source link

Vision Subsystem Commands #27

Closed deadlyvortex closed 1 year ago

deadlyvortex commented 1 year ago

close #15

deadlyvortex commented 1 year ago

open #15

deadlyvortex commented 1 year ago

open #15

deadlyvortex commented 1 year ago

close #15

deadlyvortex commented 1 year ago

open #15

danielbrownmsm commented 1 year ago

for some reason deadlyvortex's commits were showing up as mine, probably because that was probably the computer I used last year. That should be all git config'ed and fixed now, though

jkleiber commented 1 year ago

Another comment @deadlyvortex - you need to change the "Subsystems" folder to be named "subsystems" (lower case name). The reason the build fails is because of this

jkleiber commented 1 year ago

Sorry for all the spam guys. The issue is not with our code - this is due to a known issue in the WPILib DataLogger: https://github.com/wpilibsuite/allwpilib/issues/5120

master fails to build on my Linux computer as well, so for now we will be without CI - I will lift the requirement on the CI checks passing, and we'll wait to see if they can fix this issue. For now, we will work on the honor system if it builds locally on a windows laptop.

jkleiber commented 1 year ago

@deadlyvortex since you did most of the work on this, please merge it whenever you get the chance

gaborszita commented 1 year ago

Sorry for all the spam guys. The issue is not with our code - this is due to a known issue in the WPILib DataLogger: wpilibsuite/allwpilib#5120

master fails to build on my Linux computer as well, so for now we will be without CI - I will lift the requirement on the CI checks passing, and we'll wait to see if they can fix this issue. For now, we will work on the honor system if it builds locally on a windows laptop.

I'm looking into this error and see if I can fix it. In the meantime, try disabling network tables logging by DataLogManager::LogNetworkTables(false) since that removed the error for me.

gaborszita commented 1 year ago

Sorry for all the spam guys. The issue is not with our code - this is due to a known issue in the WPILib DataLogger: wpilibsuite/allwpilib#5120

master fails to build on my Linux computer as well, so for now we will be without CI - I will lift the requirement on the CI checks passing, and we'll wait to see if they can fix this issue. For now, we will work on the honor system if it builds locally on a windows laptop.

Also, thank you for pointing out that the error is only present on Windows. This will make my debugging process easier.

gaborszita commented 1 year ago

It seems I fixed the issue. I'll create a PR and see if they merge it.

gaborszita commented 1 year ago

FYI @jkleiber upgrading to WPLib 2023.4.2 (you can upgrade simply by changing the GradleRIO plugin version in build.gradle) fixes the WPILib DataLogger issue.

jkleiber commented 1 year ago

@gaborszita apologies for the slow response, but thanks for fixing this issue! Unbreaking our CI is greatly appreciated 😄