Summary
The current implementation of OKC_CALL/CHECK could use a bit of an upgrade in terms of the print statement. Currently it only prints the checked/called item and not the macro wrapped around it. For example, if we have a pointer p which is nullptr OKC_CHECK would show: p != nullptr instead of the possibly more helpful OKC_CHECK(p != nullptr);. The goal of this ticket is to improve the checks so it's easier to see what's going on.
Work
Improve prints for checks and calls as described above.
Verification
CI passes
Unit tests show calls and checks fail with good error messages
Summary The current implementation of OKC_CALL/CHECK could use a bit of an upgrade in terms of the print statement. Currently it only prints the checked/called item and not the macro wrapped around it. For example, if we have a pointer
p
which isnullptr
OKC_CHECK would show:p != nullptr
instead of the possibly more helpfulOKC_CHECK(p != nullptr);
. The goal of this ticket is to improve the checks so it's easier to see what's going on.Work
Verification