Team-RAM / RAM

Randomly Added Mods
6 stars 4 forks source link

Memory Leak and disconnects (due to ghost blocks) #67

Open Ruchian opened 4 years ago

Ruchian commented 4 years ago

afbeelding some mod or mods are apparently having issues, or at least load themselves up multiple times. This naturally can be confirmed by connecting and disconnecting from a server (for whatever reason) many times in a row. I do not know which mod it is that fails to get garbage collected, but it's annoying. The only way to circumvent it is by doing a restart.

I also discovered an issue with Yet Another Mining Dimension Attempt that can be repeated at least on the multiplayer server I play. By right clicking while holding a block on the Mining Dimension Portal to travel to the overworld, it will sometimes place the block on top of the portal block, just before you teleport; then removing it. However it turns out the block still exists in memory. This can also happen when opening a Cyclic Item Collector's inventory while holding a block. It might place it, even though it isn't placed. The client keeps this data loaded in and it can cause disconnections. The only way to fix it is by purposely placing and removing a block to replace the dummy air block there.

Evidence that ghost blocks remain loaded can be seen on the server as well in some cases. The Mining Dim portal block might create a duplicate of itself in mid air that is only visible to the client who accidentally held dirt in the hand while right clicking the portal block to travel to the overworld (causing the dirt to be placed while going to the overworld). When it is visible, right clicking on the dummy portal block in air with Dirt in the hand, causes it to be replaced with Dirt. This causes a floating block of dirt in the air. This maybe an innocent glitch at first glance that maybe useful, but it can cause timeouts and disconnection issues when a player uses the real portal block as well, so I recommend to others who encounter this, to try and clean these glitches.

I'm not sure what the pack creator can do other than investigate this further; as a player I don't really want to try and test which mod is causing these issues to happen. @Sunekaer (I'll ping you since I suspect this affects your mod mostly. It really doesn't like ghost blocks that shouldn't exist on a server.)

Edit: fyi YAMDA version 5.0.3, minecraft 1.15.2. (cyclic 0.4.2). edit 2: forgot forge version Tested and confirmed on forge version 31.2.27 and 31.2.31. (updating didn't do much xd)