search

Team-RTG / Realistic-Terrain-Generation

The Realistic Terrain Generation mod for Minecraft.
GNU General Public License v3.0
245 stars 118 forks source link

Remove CustomizeBlockEvent #1302

Closed srs-bsns closed 5 years ago

srs-bsns commented 5 years ago

The CustomizeBlockEvent isn't really useful as the blocks can just be set via configs and should remain world persistent. It is highly unlikely that any mod would utilise this event (which would require a dependency on the RTG API) and it creates an environment in which another mod could corrupt the world by arbitrarily changing which blocks are used during chunk generation.

whichonespink44 commented 5 years ago

IIRC, this event was added to allow UBC to 'do its thang' with RTG's boulders, so if UBC isn't using this event, then I don't see any harm in removing it. But either way, I don't think this needs to be sorted before we release for 1.12

Aang23 commented 5 years ago

No UBC doesn't use that event anymore in 1.12.2.

whichonespink44 commented 5 years ago

Then we burn it to the ground!!! 🔥🔥🔥

srs-bsns commented 5 years ago

Closed in https://github.com/Team-RTG/Realistic-Terrain-Generation/commit/d6b7a9323a5aeb93ef4834ddc46ec3c47bc3f7fa