search

Team-RTG / Realistic-Terrain-Generation

The Realistic Terrain Generation mod for Minecraft.
GNU General Public License v3.0
245 stars 118 forks source link

Disable lava lakes on the surface by default #1312

Closed whichonespink44 closed 5 years ago

whichonespink44 commented 5 years ago

Not sure about the best way to go about this, but those surface lava lakes have to go as they just mutilate the landscape.

Maybe a config option, but definitely disabled by default.

whichonespink44 commented 5 years ago

Fixed in 04c7602

srs-bsns commented 5 years ago
  1. The API shouldn't be referencing stuff outside of it like that. (This should have been done in RealisticBiomeBase)
  2. This is also a bad way to do it as there are implementers that override that method which will completely ignore the config setting.
  3. If you are going to make it configurable via a config setting, then that method becomes pointless.
whichonespink44 commented 5 years ago
  1. The API shouldn't be referencing stuff outside of it like that. (This should have been done in RealisticBiomeBase)

Where is the API referencing something outside of it?