Team-RTG / Realistic-Terrain-Generation

The Realistic Terrain Generation mod for Minecraft.
GNU General Public License v3.0
245 stars 118 forks source link

Added biome support for Ice and Fire. #1336

Closed tie closed 4 years ago

tie commented 4 years ago

Brings back iceandfire:glacier biome support from dcf2bbe.

I also did some changes (see below) in initDeco and initConfig because (a) SURFACE_*_META properties were removed, (b) I don’t understand their impact on the terrain generation. Please, let me know if they are essential for biome gen.

diff highlights ```diff package rtg.world.biome.realistic.iceandfire; […] public class […] { […] @Override public void initConfig() { - this.getConfig().addProperty(this.getConfig().SURFACE_MIX_BLOCK).set(""); - this.getConfig().addProperty(this.getConfig().SURFACE_MIX_BLOCK_META).set(0); - this.getConfig().addProperty(this.getConfig().SURFACE_MIX_FILLER_BLOCK).set(""); - this.getConfig().addProperty(this.getConfig().SURFACE_MIX_FILLER_BLOCK_META).set(0); } […] public class SurfaceIAFGlacier extends SurfaceBase { […] public SurfaceIAFGlacier(BiomeConfig config, IBlockState top, IBlockState filler, IBlockState mixTop, IBlockState mixFill, IBlockState cliff1, IBlockState cliff2, float mixWidth, float mixHeight, float smallWidth, float smallStrength) { super(config, top, filler); - mixBlockTop = this.getConfigBlock(config.SURFACE_MIX_BLOCK.get(), config.SURFACE_MIX_BLOCK_META.get(), mixTop); - mixBlockFill = this.getConfigBlock(config.SURFACE_MIX_FILLER_BLOCK.get(), config.SURFACE_MIX_FILLER_BLOCK_META.get(), mixFill); + mixBlockTop = this.getConfigBlock(config.SURFACE_MIX_BLOCK.get(), mixTop); + mixBlockFill = this.getConfigBlock(config.SURFACE_MIX_FILLER_BLOCK.get(), mixFill); […] } […] } @Override public void initDecos() { - DecoBaseBiomeDecorations decoBaseBiomeDecorations = new DecoBaseBiomeDecorations(); - this.addDeco(decoBaseBiomeDecorations); } } ```
srs-bsns commented 4 years ago

I already have a changeset that readds support for Ice And Fire, it's just not merged/pushed yet. I am refraining from adding support for new biomes until I have finished the GenLayer system and have assessed if any refactoring needs to be done first.